Skip to content

fix(application-shell): keep notifications visible when scrolling down #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ragafus wants to merge 2 commits into from
Closed

fix(application-shell): keep notifications visible when scrolling down #3846

ragafus wants to merge 2 commits into from
+7 −1

Conversation

@ragafus
Copy link
Contributor

@ragafus ragafus commented Sep 17, 2025 •
edited
Loading

Summary

MC apps hide notifications if the user has scrolled down the content. This happens because we are scrolling main, which hosts the notifications.

Priceless ticket https://commercetools.atlassian.net/browse/PRC-4262

Description

Before

before.mov

After

after.mov

@ragafus ragafus self-assigned this Sep 17, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c3ca39e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/application-shell Patch
@commercetools-frontend/cypress Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-local/visual-testing-app Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/mc-scripts Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-website/components-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
mc-app-kit-playground Ready Ready Preview Comment Sep 17, 2025 2:23pm
merchant-center-application-kit-components-playground Ready Ready Preview Comment Sep 17, 2025 2:23pm

@ragafus ragafus requested a review from nima-ct September 17, 2025 14:01
@ragafus ragafus marked this pull request as ready for review September 17, 2025 14:01
@ragafus ragafus requested a review from a team as a code owner September 17, 2025 14:01
@ragafus ragafus force-pushed the PRC-4262-hidden-notifications branch from fc8e5db to c3ca39e Compare September 17, 2025 14:21
@ddouglasz
Copy link
Contributor

ddouglasz commented Sep 18, 2025 •
edited
Loading

@commercetools/craft-team-fe please take a look 👀
⚠️ Since this is sort a "root" change that affects a lot of places in our applications, although approved, we should not merge yet until we can test that it is visually consistent in all possible use cases.

misama-ct
misama-ct requested changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@misama-ct misama-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change touches layers that should not be responsible for the intended change. The fact that the navigation appears sticky now is merely a side-effect.

Having that said: I can't tell you how to to achieve sticky notifications that reliably work the same across all applications without spending a significant amount of time on investigating the DOM structure and the surrounding css-rules.

@ragafus ragafus closed this Jan 13, 2026
@ragafus ragafus deleted the PRC-4262-hidden-notifications branch January 13, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@misama-ct misama-ct misama-ct requested changes

@ddouglasz ddouglasz ddouglasz approved these changes

@nima-ct nima-ct Awaiting requested review from nima-ct

Assignees

@ragafus ragafus

Labels

🛑 Status: blocked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ragafus @ddouglasz @misama-ct